Add Effect notes and migration plan notes #215
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ E2E Tests Passed3 passed
|
Implements the foundation for gradual Effect-TS migration: - Install effect package - Create tagged error types for typed error handling - Create runtime helpers to bridge Effect with Promise-based code - Create observability bridge for Sentry span integration - Create Database Service wrapping Kysely with typed errors - Convert userThreads model as first Effect-based model example 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Upgrade @sentry/node to v8 with skipOpenTelemetrySetup - Add @effect/opentelemetry and OpenTelemetry SDK packages - Add @sentry/opentelemetry for span export - Add posthog-node for future server-side analytics - Create tracing.ts with SentrySpanProcessor, SentrySampler, SentryPropagator - Update runtime.ts to provide TracingLive layer to all effects Effects using Effect.withSpan will now have their spans exported to Sentry for visualization in the Performance dashboard. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Updates modLog.ts to use the Effect-based userThreads implementation via the legacy wrapper functions. This validates the Effect migration approach while maintaining backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Create app/effects/models/reportedMessages.ts with Effect-based functions - Update all imports to use Effect-based version with legacy wrappers - Delete dead app/models/reportedMessages.server.ts Functions migrated: - recordReport (with DatabaseConstraintError handling) - getReportsForUser - getReportsForMessage - getUserReportStats - deleteReport - markMessageAsDeleted - getUniqueNonDeletedMessages - deleteAllReportedForUser (partial - still uses Discord client directly) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.